Comments on: WP-Typogrify Hacked to Work With WP-Captions http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/ Just another WordPress weblog Wed, 28 Jul 2010 03:25:21 +0000 hourly 1 http://wordpress.org/?v=3.0 By: Jeff Byrnes http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/comment-page-1/#comment-134 Jeff Byrnes Thu, 14 May 2009 04:34:38 +0000 http://davidsd.org/?p=1354#comment-134 Looks like it works! Thanks! Looks like it works! Thanks!

]]> By: davidsd http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/comment-page-1/#comment-133 davidsd Thu, 14 May 2009 00:31:38 +0000 http://davidsd.org/?p=1354#comment-133 @<a href="http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/comment-page-1/#comment-132" rel="nofollow">Jeff</a>, maybe the problem is that the _TokenizeHTML function as it's written doesn't recognize underscores in tag names. Try replacing <code>[-a-zA-Z0-9:]</code> with <code>[-a-zA-Z0-9:_]</code> in line 10 of block (3) above. @Jeff, maybe the problem is that the _TokenizeHTML function as it’s written doesn’t recognize underscores in tag names. Try replacing [-a-zA-Z0-9:] with [-a-zA-Z0-9:_] in line 10 of block (3) above.

]]> By: Jeff Byrnes http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/comment-page-1/#comment-132 Jeff Byrnes Wed, 13 May 2009 22:59:39 +0000 http://davidsd.org/?p=1354#comment-132 I've actually had the same issue with my site & the Kimili Flash Embed code (uses [kml_flashembed] as a tag), and I couldn't get your hack/fix to work. Added kml_flashembed to the list of tags in this bit: <code>$sp_tags_to_skip = '(?:]|'. '\[(/?)(?:caption|code|php)[\s\]])';</code> Any suggestions? I’ve actually had the same issue with my site & the Kimili Flash Embed code (uses [kml_flashembed] as a tag), and I couldn’t get your hack/fix to work. Added kml_flashembed to the list of tags in this bit:

$sp_tags_to_skip = '(?:]|'.
'\[(/?)(?:caption|code|php)[\s\]])';

Any suggestions?

]]> By: Greg Price http://davidsd.org/2009/04/wp-typogrify-hacked-to-work-with-wp-captions/comment-page-1/#comment-119 Greg Price Tue, 12 May 2009 05:09:26 +0000 http://davidsd.org/?p=1354#comment-119 Cool. Have you sent your changes to the developer? That's a good way of making your fix easy for other people to get, and also of guaranteeing that the next version will have your fixes so you don't have to repeat them. Sometimes maintainers are busy and it takes a while, and sometimes they're lame and never deal with a patch, but it's generally worth it. Cool. Have you sent your changes to the developer? That’s a good way of making your fix easy for other people to get, and also of guaranteeing that the next version will have your fixes so you don’t have to repeat them.

Sometimes maintainers are busy and it takes a while, and sometimes they’re lame and never deal with a patch, but it’s generally worth it.

]]>